Skip to content

I did the assignment.#2510

Open
Yehor0820 wants to merge 2 commits intomate-academy:masterfrom
Yehor0820:hw-2
Open

I did the assignment.#2510
Yehor0820 wants to merge 2 commits intomate-academy:masterfrom
Yehor0820:hw-2

Conversation

@Yehor0820
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your solution correctly implements inheritance and polymorphism, and all functional requirements are met. I am approving your submission.

As a minor point of feedback, please pay attention to code style. In all your Java files (Bulldozer.java, Excavator.java, Truck.java, MainApp.java), there are redundant empty lines after class and method declarations. This violates a checklist item [CHECKLIST ITEM #1]. While this is a stylistic issue that doesn't affect the functionality, keeping your code clean and consistent is a great habit to build.

Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

package core.basesyntax;

public class Bulldozer extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature.' This empty line should be removed.

package core.basesyntax;

public class Excavator extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature.' This empty line after the class declaration should be removed.

public void doWork() {
System.out.println("Excavator started working");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Please don't add redundant empty lines to your code.' According to the provided checklist, empty lines between methods should be avoided.

package core.basesyntax;

public class Truck extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." This empty line after the class declaration should be removed to improve code style.


public class MainApp {

public static void main(String[] args) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature.' The blank line before this method declaration is unnecessary and should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants